Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: assert updates are implicitly persisted #781

Merged
merged 1 commit into from
Jan 27, 2025
Merged

test: assert updates are implicitly persisted #781

merged 1 commit into from
Jan 27, 2025

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Jan 6, 2025 •
edited
Loading

fix of a subtle bug introduced by #773

@nikophil nikophil marked this pull request as draft January 9, 2025 18:32
@nikophil nikophil force-pushed the test/implicit-save branch 3 times, most recently from 7bdd3ce to eb3de96 Compare January 24, 2025 22:00
@nikophil nikophil marked this pull request as ready for review January 24, 2025 22:02
kbond
kbond approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting solution!

@nikophil nikophil merged commit 86c5aab into zenstruck:2.x Jan 27, 2025
86 checks passed
@nikophil nikophil deleted the test/implicit-save branch January 27, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikophil @kbond